Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: add tests for built-in rules config schema validation (fixes #15) #31

Merged
merged 1 commit into from
Mar 23, 2021

Conversation

mdjermanovic
Copy link
Member

Fixes #15.

This is a follow-up to #14. I verified that all 3 tests fail without changes made in #14.

@nzakas
Copy link
Member

nzakas commented Mar 17, 2021

These tests were copied over from the main eslint repo, correct?

@mdjermanovic
Copy link
Member Author

These tests were copied over from the main eslint repo, correct?

No, these tests are made from scratch. It seems that we didn't have any tests for this in the main repo. I verified with v7.0.0: if we remove || BuiltInRules.get(id) from this line, all tests are still passing.

We added an integration test later, in eslint/eslint#13794. The "in 'baseConfig'" test added in this PR corresponds to that integration tests.

@nzakas nzakas merged commit 7c43d77 into main Mar 23, 2021
@nzakas nzakas deleted the issue15 branch March 23, 2021 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test built-in rule schema validation
2 participants